Skip to content

Add search book via ISBN using openlibrary.org API #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2021
Merged

Add search book via ISBN using openlibrary.org API #5736

merged 4 commits into from
Nov 1, 2021

Conversation

kellydosocorro
Copy link
Contributor

@kellydosocorro kellydosocorro commented Nov 1, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required labels Nov 1, 2021
ghost
ghost reviewed Nov 1, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@ghost ghost removed the require tests Tests [doctest/unittest/pytest] are required label Nov 1, 2021
@l3str4nge
Copy link
Member

I am not sure if we want to have external dependencies like this API. I think it slows down the tests. Is it algorithm actually??

@cclauss @poyea

@ghost ghost added the tests are failing Do not merge until tests pass label Nov 1, 2021
@cclauss
Copy link
Member

cclauss commented Nov 1, 2021 •
edited
Loading

@l3str4nge The web_programming directory is a bit special in that doctests are much less essential because they slow down our continuous integration and the Open Library may change the data on their end which would break our tests. I will propose a workaround to @kellydosocorro.

On the Is it an algorithm question in this directory, we have been requesting that there be some pre- or post-processing of the data to add value beyond the raw data provided by the api. So the entries in this directory are often more how-to-use-this-api rather than actual algorithms as defined in CONTRIBUTING.md but I believe that @kellydosocorro has a good submission here. Suggestions to follow…

@cclauss
Copy link
Member

cclauss commented Nov 1, 2021 •
edited
Loading

Please run psf/black on this code to reformat it as discussed in CONTRIBUTING.md to fix the failing test.

cclauss
cclauss approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 1, 2021
poyea
poyea approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 1, 2021
@cclauss cclauss merged commit 68ca61e into TheAlgorithms:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kellydosocorro @l3str4nge @cclauss @poyea